Conversation
Previously an unknown URL (e.g. from a different special remote) would crash the uncurl remote. Additionally, if a key had more than one URL registered only one was tried in some cases. Now, if the data is not found at one location or the URLs scheme is unsupported, the next URL is tried instead. Fixes datalad#770.
|
Thanks for the PR! If I understand correctly, the two changes are: (1) catch a handler crash with Can you provide a bit more insight into the situation that triggered the undesirable behavior for you? What handler tripped? On which kind of URL? Maybe some configuration is too broad in the defaults. With this change, the return value semantics of the function are a bit crippled. I want to understand, whether you point to a conceptual issue with the imolemented logic. Thanks! |
|
In the ERA5 dataset, some files are available both from the CDS using datalad-cds as well as from a data project on JUDAC called MeteoCloud. I want to register ssh:// as well as potentially file:// URLs to make DataLad and git-annex retrieve the files from the MeteoCloud project if possible. One of those files now looks like this: Now the two issues are these:
This PR fixes those two issues by skipping the URL and trying the next one instead. |
Previously an unknown URL (e.g. from a different special remote) would crash the uncurl remote. Additionally, if a key had more than one URL registered only one was tried in some cases.
Now, if the data is not found at one location or the URLs scheme is unsupported, the next URL is tried instead.
Fixes #770.